fix: allow --variable-type flag to support multiple selections#72
fix: allow --variable-type flag to support multiple selections#72SakshiKoli-CS merged 1 commit intodevelopmentfrom
Conversation
SakshiKoli-CS
force-pushed
the
cl-1656
branch
2 times, most recently
from
a5c2b95 to
9430f59
Compare
SakshiKoli-CS
force-pushed
the
cl-1656
branch
from
9430f59 to
a633ad7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables the --variable-type flag in the launch command to accept multiple selections, allowing users to combine different environment variable import methods (e.g., importing from a stack while also manually adding variables).
Key Changes
- Updated the
--variable-typeflag definition to support multiple values with themultiple: trueproperty - Added a new usage example demonstrating how to specify multiple
--variable-typeflags - Expanded test coverage with new test cases for various combinations of variable type selections
- Added AGENTS.md file with testing guidelines for the project
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/commands/launch/index.ts | Added multiple: true to the --variable-type flag definition and updated the description to clarify that the flag can be specified multiple times. Added a new example demonstrating multiple flag usage. |
| src/adapters/base-class.test.ts | Added comprehensive test cases for handling multiple variable type selections, including combinations of two options, all three options, and edge cases for the "Skip" option validation. |
| AGENTS.md | New file containing testing guidelines and best practices for writing unit tests in the project. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SakshiKoli-CS
force-pushed
the
cl-1656
branch
from
a633ad7 to
55b16de
Compare
SakshiKoli-CS
dismissed stale reviews from anonyda, venky0195, and tejas-contentstack
via
4d88437
SakshiKoli-CS
force-pushed
the
cl-1656
branch
from
55b16de to
4d88437
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 participants
No description provided.